pyproject: Stop disabling urllib3 import checks in mypy#2188
Merged
lukpueh merged 1 commit intotheupdateframework:developfrom Nov 21, 2022
Merged
pyproject: Stop disabling urllib3 import checks in mypy#2188lukpueh merged 1 commit intotheupdateframework:developfrom
lukpueh merged 1 commit intotheupdateframework:developfrom
Conversation
Double reasoning for this one: * urllib3 now does have annotations * since we don't import requests annotations (to avoid depending on typeshed) urllib3 annotations are never needed: we don't use urllib3 directly Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Pull Request Test Coverage Report for Build 3513358673
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3513358673Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 3513358673Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double reasoning for this one:
Signed-off-by: Jussi Kukkonen jkukkonen@google.com